tiagobento commented on code in PR #2508:
URL:
https://github.com/apache/incubator-kie-tools/pull/2508#discussion_r1706201378
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -992,8 +992,9 @@ export const Diagram = React.forwardRef<DiagramRef, {
container: React.RefObject
for (let i = 0; i < selectedNodes.length; i++) {
deleteDecisionFromDecisionService({
definitions: state.dmn.model.definitions,
- decisionId: selectedNodes[i].data.dmnObject!["@_id"]!, //
We can assume that all selected nodes are Decisions because the contaiment was
validated above.
+ decisionId: selectedNodes[i].id, // We can assume that all
selected nodes are Decisions because the contaiment was validated above.
Review Comment:
- "Full ID" = href
- href = `namespace#XSD:ID`
- xsd:ID = typically the `"@_id"` attribute of objects
- namespace = `definitions["@_namespace"]`
##########
packages/dmn-editor/src/diagram/Diagram.tsx:
##########
@@ -992,8 +992,9 @@ export const Diagram = React.forwardRef<DiagramRef, {
container: React.RefObject
for (let i = 0; i < selectedNodes.length; i++) {
deleteDecisionFromDecisionService({
definitions: state.dmn.model.definitions,
- decisionId: selectedNodes[i].data.dmnObject!["@_id"]!, //
We can assume that all selected nodes are Decisions because the contaiment was
validated above.
+ decisionId: selectedNodes[i].id, // We can assume that all
selected nodes are Decisions because the contaiment was validated above.
Review Comment:
- "Full ID" = href
- href = `namespace#xsd:ID`
- xsd:ID = typically the `"@_id"` attribute of objects
- namespace = `definitions["@_namespace"]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
