fjtirado commented on code in PR #1988:
URL:
https://github.com/apache/incubator-kie-kogito-examples/pull/1988#discussion_r1708939485
##########
kogito-quarkus-examples/decisiontable-quarkus-example/pom.xml:
##########
@@ -29,37 +29,26 @@
</parent>
<artifactId>decisiontable-quarkus-example</artifactId>
<name>Kogito Example :: Decision Table - Quarkus</name>
- <properties>
- <quarkus-plugin.version>3.8.4</quarkus-plugin.version>
- <quarkus.platform.artifact-id>quarkus-bom</quarkus.platform.artifact-id>
- <quarkus.platform.group-id>io.quarkus</quarkus.platform.group-id>
- <quarkus.platform.version>3.8.4</quarkus.platform.version>
- <kogito.bom.group-id>org.kie.kogito</kogito.bom.group-id>
- <kogito.bom.artifact-id>kogito-bom</kogito.bom.artifact-id>
- <kogito.bom.version>999-SNAPSHOT</kogito.bom.version>
- <version.org.kie.kogito>999-SNAPSHOT</version.org.kie.kogito>
- <version.org.drools>999-SNAPSHOT</version.org.drools>
- </properties>
<dependencyManagement>
<dependencies>
<dependency>
- <groupId>${quarkus.platform.group-id}</groupId>
- <artifactId>${quarkus.platform.artifact-id}</artifactId>
- <version>${quarkus.platform.version}</version>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-bom</artifactId>
+ <version>3.8.4</version>
Review Comment:
In my opinion, version (Kogito one, which is used twice in the same file and
even quarkus one, which is used once, that way the two will be together) should
be kept in properties block. It will be easier to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
