jomarko commented on code in PR #2336: URL: https://github.com/apache/incubator-kie-tools/pull/2336#discussion_r1709222512
########## packages/boxed-expression-component/tests-e2e/boxedExpressions/conditional/populate.spec.ts: ########## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import _ from "lodash"; +import { test, expect } from "../../__fixtures__/base"; + +test.describe("Populate Boxed Conditional", () => { + test("should rename a Conditional", async ({ bee, stories }) => { + await stories.openBoxedConditional(); + + await bee.expression.asConditional().expressionHeaderCell.open(); + await bee.expression + .asConditional() + .expressionHeaderCell.setName({ name: "Conditional Expression Name", close: true }); + + expect(await bee.expression.asConditional().expressionHeaderCell.content.textContent()).toEqual( + "Conditional Expression Name(<Undefined>)" + ); + }); + + test("should change a Conditional data type", async ({ bee, stories }) => { + await stories.openBoxedConditional(); + + await bee.expression.asConditional().expressionHeaderCell.open(); + await bee.expression.asConditional().expressionHeaderCell.setDataType({ dataType: "boolean", close: true }); + + expect(await bee.expression.asConditional().expressionHeaderCell.content.textContent()).toEqual( + "Expression Name(boolean)" + ); + }); + + test("should create the Monthly Fee Conditional", async ({ bee, stories }) => { + await stories.openBoxedConditional(); + + // HEADER + await bee.expression.asConditional().expressionHeaderCell.open(); + await bee.expression.asConditional().expressionHeaderCell.setName({ name: "MonthlyFee", close: false }); + await bee.expression.asConditional().expressionHeaderCell.setDataType({ dataType: "number", close: true }); + + // IF + await bee.expression.asConditional().if.expression.asLiteral().fill('ProdctType = "STANDARD LOAN"'); + + // THEN + await bee.expression.asConditional().then.expression.asLiteral().fill("20"); + + // ELSE + await bee.expression.asConditional().else.expression.asLiteral().equalsSignCell.open(); + await bee.expression.asConditional().else.expression.asLiteral().equalsSignCell.reset(); + await bee.expression.asConditional().else.selectExpressionMenu.selectConditional(); + await bee.expression.asConditional().else.expression.asConditional().if.selectExpressionMenu.selectLiteral(); + await bee.expression + .asConditional() + .else.expression.asConditional() + .if.expression.asLiteral() + .fill('ProdctType = "SPECIAL OFFERING"'); + await bee.expression.asConditional().else.expression.asConditional().then.selectExpressionMenu.selectLiteral(); + await bee.expression.asConditional().else.expression.asConditional().then.expression.asLiteral().fill("25"); + await bee.expression.asConditional().else.expression.asConditional().else.selectExpressionMenu.selectLiteral(); + await bee.expression.asConditional().else.expression.asConditional().else.expression.asLiteral().fill("null"); + + await expect(bee.getContainer()).toHaveScreenshot("boxed-conditional-monthly-fee.png"); + }); + + test("should create a nested Conditional", async ({ bee, stories }) => { + await stories.openBoxedConditional(); + + await bee.expression.header.reset(); + await bee.selectExpressionMenu.selectContext(); + await bee.expression.asContext().entry(0).selectExpressionMenu.selectConditional(); + + await bee.expression.asContext().entry(0).expression.asConditional().if.selectExpressionMenu.selectLiteral(); + await bee.expression.asContext().entry(0).expression.asConditional().if.expression.asLiteral().fill("1 > 0"); + + await bee.expression.asContext().entry(0).expression.asConditional().then.selectExpressionMenu.selectLiteral(); + await bee.expression.asContext().entry(0).expression.asConditional().then.expression.asLiteral().fill("always"); + + await bee.expression.asContext().entry(0).expression.asConditional().else.selectExpressionMenu.selectLiteral(); + await bee.expression.asContext().entry(0).expression.asConditional().else.expression.asLiteral().fill("never"); + + await expect(bee.getContainer()).toHaveScreenshot("nested-boxed-conditional.png"); + }); + + test("should combine other expressions with the Conditional", async ({ bee, stories }) => { + await stories.openBoxedConditional(); + + await bee.expression.asConditional().if.expression.asLiteral().equalsSignCell.open(); + await bee.expression.asConditional().if.expression.asLiteral().equalsSignCell.reset(); Review Comment: well, I do not think I can apply your suggestion completely, because the suggestion you provided, is about this context menu:  that is different from this, equals sign, context menu:  however, at least, I will try to reuse the existing type `ContextMenu` and will remove the file `equalsSignCell.ts` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
