danielzhe commented on code in PR #2527:
URL:
https://github.com/apache/incubator-kie-tools/pull/2527#discussion_r1710258427
##########
packages/boxed-expression-component/src/resizing/Hooks.tsx:
##########
@@ -68,7 +68,11 @@ export function useNestedExpressionResizingWidthValue(
return Math.max(
nestedExpressionContainerResizingWidthValue -
fixedColumnResizingWidth.value - extraWidth,
- ...nestedExpressions.map((e) => getExpressionResizingWidth(e, new Map(),
widthsById)),
Review Comment:
After spending hours it looks like it was in fact a simple issue hard to
find: the extraWidth for nested expressions was not being considered here. This
issue was only noticeable when the upper cell was LESS WIDE than the bottom one.
Also, this fixed another issue we had with resizing that was causing some
"jumps" in this scenario. I'll share a video to show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
