danielzhe commented on code in PR #2508:
URL:
https://github.com/apache/incubator-kie-tools/pull/2508#discussion_r1711561671
##########
packages/dmn-editor/tests-e2e/__fixtures__/palette.ts:
##########
@@ -40,6 +40,21 @@ export class Palette {
}
}
+ public async dragExternalNode(args: {
+ includedModelName: string;
+ nodeName: string;
+ targetPosition: { x: number; y: number };
+ }) {
+ await this.page
+ .getByTestId("kie-tools--dmn-editor--external-nodes-popover")
+
.getByTestId(`kie-tools--dmn-editor--external-node-${args.includedModelName}-${args.nodeName}`)
Review Comment:
If the included model is empty, then nothing will happen, but if the
included model exists, we will use its name (which is optional, as you spotted)
or its id if the name is not present.
I'm replying the other question there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
