Abhitocode commented on code in PR #3610:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3610#discussion_r1717853786
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java:
##########
@@ -1109,62 +1166,59 @@ public void testTimerBoundaryEventCycleISO() throws
Exception {
}
@Test
- public void testTimerBoundaryEventInterrupting() throws Exception {
- ProcessCompletedCountDownProcessEventListener countDownListener = new
ProcessCompletedCountDownProcessEventListener();
+ public void testTimerBoundaryEventInterrupting() {
+ ProcessCompletedCountDownProcessEventListener countDownListener = new
ProcessCompletedCountDownProcessEventListener(2);
Review Comment:
added additional assertions as below:
```
List<ProcessNodeEvent> processNodeEvents = trackerListener.tracked();
assertThat(processNodeEvents.size()).isEqualTo(13);
assertThat(processNodeEvents).anyMatch(ProcessTestHelper.triggered("StartProcess"))
.anyMatch(ProcessTestHelper.triggered("StartSubProcess"))
.anyMatch(ProcessTestHelper.left("Hello"))
.anyMatch(ProcessTestHelper.left("Goodbye"))
.anyMatch(ProcessTestHelper.triggered("Task"))
.anyMatch(ProcessTestHelper.triggered("EndProcess"));
```
but the process instance is completed only incase of
`countDownListener= new ProcessCompletedCountDownProcessEventListener(2);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
