Abhitocode opened a new pull request, #3626: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3626
In addition to previous changes associated, Migrated tests within FeelTest.java The test can be identified by referring to FeelTest.java: https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FeelTest.java Closes https://github.com/apache/incubator-kie-issues/issues/1131. **NOTE**: This PR still contains issues, will update and push once resolved. **Issue 1**: `testGatewayFEEL` The model does not have variables Task1, Task2, and Task3, so we are not able to assert the below assertions. ```assertThat(procInstance1.variables().toMap().get("Task1")).isEqualTo("ok"); assertThat(procInstance1.variables().toMap().get("Task2")).isEqualTo("ok") assertThat(procInstance1.variables().toMap().get("Task3")).isNull(); assertThat(eventTrackerProcessListener.tracked()).anyMatch(ProcessTestHelper.triggered("Task2")) .anyMatch(ProcessTestHelper.triggered("VA and not(VB)"));``` Task3 is not triggered ```assertThat(eventTrackerProcessListener.tracked()).anyMatch(ProcessTestHelper.triggered("Task3")) .anyMatch(ProcessTestHelper.triggered("VB or not(VA)"));``` **Issue 2**: Expected a Runtime assertion is thrown. But assertion fails as no exception is found ```Public void testGatewayFEELWrong() { Application app = ProcessTestHelper.newApplication(); org.kie.kogito.process.Process<GatewayFEELModel> process = GatewayFEELProcess.newProcess(app); assertThatExceptionOfType(RuntimeException.class) .isThrownBy(() -> { process.createInstance(process.createModel()).start(); }) .withMessageContaining("Invalid FEEL expression: 'VA and Not(VB)'") .withMessageContaining("Invalid FEEL expression: 'VB or nOt(VA)'");``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
