This is an automated email from the ASF dual-hosted git repository.
kbowers pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new 745be5dd560 kie-issues#981: On the DMN Editor it should be possible to
create or associate a Knowledge Source node to a Text Annotation node (#2525)
745be5dd560 is described below
commit 745be5dd56063ccbd2ab5ef62f340e412781ec0b
Author: Jozef Marko <[email protected]>
AuthorDate: Tue Aug 20 09:06:21 2024 +0200
kie-issues#981: On the DMN Editor it should be possible to create or
associate a Knowledge Source node to a Text Annotation node (#2525)
---
.../src/diagram/connections/graphStructure.ts | 1 +
...om-knowledge-source-node-to-text-annotation-node.png | Bin 0 -> 43822 bytes
.../add-text-annotation-from-knowledge-source.png | Bin 0 -> 44380 bytes
...om-knowledge-source-node-to-text-annotation-node.png | Bin 0 -> 38776 bytes
.../add-text-annotation-from-knowledge-source.png | Bin 0 -> 40196 bytes
...om-knowledge-source-node-to-text-annotation-node.png | Bin 0 -> 34439 bytes
.../add-text-annotation-from-knowledge-source.png | Bin 0 -> 36773 bytes
.../tests-e2e/drdArtifacts/addAssociation.spec.ts | 1 -
.../tests-e2e/drdArtifacts/addTextAnnotation.spec.ts | 1 -
9 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/packages/dmn-editor/src/diagram/connections/graphStructure.ts
b/packages/dmn-editor/src/diagram/connections/graphStructure.ts
index a77b1961d97..fdcf10d4b3a 100644
--- a/packages/dmn-editor/src/diagram/connections/graphStructure.ts
+++ b/packages/dmn-editor/src/diagram/connections/graphStructure.ts
@@ -60,6 +60,7 @@ export const graphStructure: Map<NodeType, Map<EdgeType,
Set<NodeType>>> = new M
NODE_TYPES.knowledgeSource,
new Map<EdgeType, Set<NodeType>>([
[EDGE_TYPES.authorityRequirement, new Set([NODE_TYPES.decision,
NODE_TYPES.bkm, NODE_TYPES.knowledgeSource])],
+ [EDGE_TYPES.association, new Set([NODE_TYPES.textAnnotation])],
]),
],
[
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
new file mode 100644
index 00000000000..2c7beb94668
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
differ
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-text-annotation-from-knowledge-source.png
b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-text-annotation-from-knowledge-source.png
new file mode 100644
index 00000000000..74e4b78038b
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/Google-Chrome/drdArtifacts/add-text-annotation-from-knowledge-source.png
differ
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
new file mode 100644
index 00000000000..a70b1828834
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
differ
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-text-annotation-from-knowledge-source.png
b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-text-annotation-from-knowledge-source.png
new file mode 100644
index 00000000000..49e55f55ce4
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/chromium/drdArtifacts/add-text-annotation-from-knowledge-source.png
differ
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
new file mode 100644
index 00000000000..d295462bc2c
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-association-edge-from-knowledge-source-node-to-text-annotation-node.png
differ
diff --git
a/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-text-annotation-from-knowledge-source.png
b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-text-annotation-from-knowledge-source.png
new file mode 100644
index 00000000000..0b25c2c8c96
Binary files /dev/null and
b/packages/dmn-editor/tests-e2e/__screenshots__/webkit/drdArtifacts/add-text-annotation-from-knowledge-source.png
differ
diff --git a/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
b/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
index 25b09449bb3..1526752da8b 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/addAssociation.spec.ts
@@ -85,7 +85,6 @@ test.describe("Add edge - Association", () => {
nodes,
edges,
}) => {
- test.skip(true,
"https://github.com/apache/incubator-kie-issues/issues/981";);
test.info().annotations.push({
type: TestAnnotations.REGRESSION,
description:
"https://github.com/apache/incubator-kie-issues/issues/981";,
diff --git
a/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
b/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
index 396a26e2561..868ce7b91b2 100644
--- a/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
+++ b/packages/dmn-editor/tests-e2e/drdArtifacts/addTextAnnotation.spec.ts
@@ -127,7 +127,6 @@ test.describe("Add node - Text Annotation", () => {
nodes,
edges,
}) => {
- test.skip(true,
"https://github.com/apache/incubator-kie-issues/issues/981";);
test.info().annotations.push({
type: TestAnnotations.REGRESSION,
description:
"https://github.com/apache/incubator-kie-issues/issues/981";,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
