tiagobento commented on code in PR #2532: URL: https://github.com/apache/incubator-kie-tools/pull/2532#discussion_r1727566169
########## packages/sonataflow-mock-server/README.md: ########## @@ -0,0 +1,11 @@ +# SonataFlow Mock Server + +### Description + +The SonataFlow Mock Server provides the SonataFlow GraphQL and OpenAPI endpoints. + +### Usage + +To run the development server, use the following command: + +`pnpm start` Review Comment: @fantonangeli The way I see it, the fact that this is a mock is just an implementation detail, so naming this according to the inner works of the package would be leaking out irrelevant information for consumers. In my experience naming things, we should try and convey intention, rather than description. The purpose of this app is to act as a normal SonataFlow app for other services, but it happens to be that it is entirely mocked. The APIs work normally, though, right? The word "server" here doesn't connect to anything we do, really, as we don't call a SonataFlow app a "server"... @ricardozanini Do you mind sharing your thoughts here too please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
