yesamer commented on code in PR #6055: URL: https://github.com/apache/incubator-kie-drools/pull/6055#discussion_r1730995022
########## kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/MatchesFunction.java: ########## @@ -18,16 +18,21 @@ */ package org.kie.dmn.feel.runtime.functions; +import java.security.InvalidParameterException; Review Comment: @bncriju My point is: that expection is part of the `java.security` package. That means it should be used in the security management scope (as described here https://docs.oracle.com/javase/8/docs/api/java/security/InvalidParameterException.html). In our context, [IllegalArgumentException](https://docs.oracle.com/javase/8/docs/api/java/lang/IllegalArgumentException.html) should be used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
