tiagobento commented on code in PR #2559:
URL:
https://github.com/apache/incubator-kie-tools/pull/2559#discussion_r1745750170
##########
packages/online-editor/package.json:
##########
@@ -123,5 +121,9 @@
"webpack-cli": "^4.10.0",
"webpack-dev-server": "^4.15.1",
"webpack-merge": "^5.9.0"
+ },
+ "peerDependencies": {
+ "react": ">=17.0.2 <19.0.0",
+ "react-dom": ">=17.0.2 <19.0.0"
Review Comment:
So `online-editor` is not a library... But it's also not something we
publish as a package (hence `"private": true`). But I don't know... it doesn't
feel right to put React and React DOM as peerDependencies? Also not as
dependencies, since it really is just used by Webpack during bundling. Maybe
`devDependencies` would be the correct place for all dependencies of
private-application packages? Kind of a philosophical debate I know 😄 but I'd
love to hear your thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
