tkobayas commented on code in PR #6074:
URL:
https://github.com/apache/incubator-kie-drools/pull/6074#discussion_r1749619021
##########
.ci/jenkins/Jenkinsfile.weekly.deploy:
##########
@@ -91,7 +91,7 @@ pipeline {
withCredentials([usernamePassword(credentialsId:
env.MAVEN_REPO_CREDS_ID, usernameVariable: 'REPOSITORY_USER', passwordVariable:
'REPOSITORY_TOKEN')]) {
def installOrDeploy
if (shouldDeployToRepository()) {
- installOrDeploy = "deploy -DdeployAtEnd
-Dapache.repository.username=${REPOSITORY_USER}
-Dapache.repository.password=${REPOSITORY_TOKEN}
-DretryFailedDeploymentCount=5" +
+ installOrDeploy = "deploy
-Dapache.repository.username=${REPOSITORY_USER}
-Dapache.repository.password=${REPOSITORY_TOKEN}
-DretryFailedDeploymentCount=5" +
Review Comment:
When we enable `deployAtEnd`, `retryFailedDeploymentCount` retries
uploading for *all* artifacts regardless of the artifact was successfully
deployed at the previous attempt or not. It results in the pretty long "retry".
(One attempt is around 35 minutes)
By disabling `deployAtEnd`, uploading/retrying will be done per-artifact
basis. So the retrying would give quicker and stable result.
One downside is that if a sub module in the drools repo fails to build, we
cannot rollback the already uploaded artifacts. But is it a serious issue? If
we fail to upload artifacts in the middle, it would result in the same
situation (= only some artifacts are uploaded).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
