samuel-beniamin commented on PR #6080: URL: https://github.com/apache/incubator-kie-drools/pull/6080#issuecomment-2346365889
> Hi @samuel-beniamin Reading the original ticket, it seems there is some sort of issue in the implementation. But IINW, this PR does not change the implementation at all (if just add a log), and rather modifies a test: could you clarify that ? Hello @gitgabrio, It is in the implementation, I can still see my change returning or exiting early incase the model is not the same. <img width="837" alt="Screenshot 2024-09-12 at 15 53 20" src="https://github.com/user-attachments/assets/7d01f02a-1c93-487c-977f-fc698d2c6e21";> So basically, the compiler calls this callback regardless of the model it is trying to evaluate, but in this case the extra check is basically the fix, it seems trivial but it is blocking if we need to load multiple models. ```java if (cModel != model) { return; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
