lordrip opened a new issue, #2584:
URL: https://github.com/apache/incubator-kie-tools/issues/2584

   Is it possible to make the private constructor arguments protected in [the 
DefaultVsCodeKieEditorChannelApiImpl 
class](https://github.com/apache/incubator-kie-tools/blob/22835223ff1e6f9ac9709368436b112ddfc3f7fc/packages/vscode-extension/src/DefaultVsCodeKieEditorChannelApiImpl.ts)
 class?
   
   In [the DefaultVsCodeKieEditorChannelApiImpl 
class](https://github.com/apache/incubator-kie-tools/blob/22835223ff1e6f9ac9709368436b112ddfc3f7fc/packages/vscode-extension/src/DefaultVsCodeKieEditorChannelApiImpl.ts),
 all of its members are private, making complicated for other classes extending 
it to use them.
   
   Here's an extract of the constructor:
   ```diff
   export class DefaultVsCodeKieEditorChannelApiImpl implements 
KogitoEditorChannelApi, JavaCodeCompletionChannelApi {
     constructor(
   -    private readonly editor: VsCodeKieEditorController,
   -    private readonly resourceContentService: ResourceContentService,
   -    private readonly workspaceApi: WorkspaceChannelApi,
   -    private readonly backendProxy: BackendProxy,
   -    private readonly notificationsApi: NotificationsChannelApi,
   -    private readonly javaCodeCompletionApi: JavaCodeCompletionApi,
   -    private readonly viewType: string,
   -    private readonly i18n: I18n<VsCodeI18n>
   +    protected readonly editor: VsCodeKieEditorController,
   +    protected readonly resourceContentService: ResourceContentService,
   +    protected readonly workspaceApi: WorkspaceChannelApi,
   +    protected readonly backendProxy: BackendProxy,
   +    protected readonly notificationsApi: NotificationsChannelApi,
   +    protected readonly javaCodeCompletionApi: JavaCodeCompletionApi,
   +    protected readonly viewType: string,
   +    protected readonly i18n: I18n<VsCodeI18n>
     ) {}
   ```
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to