pibizza commented on code in PR #3639:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3639#discussion_r1760731984


##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java:
##########
@@ -1909,38 +2089,46 @@ public void 
testEventSubprocessSignalWithTransformation() throws Exception {
     }
 
     @Test
-    public void testMultipleMessageSignalSubprocess() throws Exception {
-        kruntime = createKogitoProcessRuntime(
-                
"org/jbpm/bpmn2/intermediate/BPMN2-MultipleMessageSignalSubprocess.bpmn2");
-        KogitoProcessInstance processInstance = 
kruntime.startProcess("MultipleMessageSignalSubprocess");
-        logger.debug("Parent Process ID: " + processInstance.getStringId());
-
-        kruntime.signalEvent("Message-Message 1", "Test", 
processInstance.getStringId());
-        assertProcessInstanceActive(processInstance.getStringId(), kruntime);
-
-        kruntime.signalEvent("Message-Message 1", "Test", 
processInstance.getStringId());
-        assertProcessInstanceCompleted(processInstance.getStringId(), 
kruntime);
+    public void testMultipleMessageSignalSubprocess() {
+        Application app = ProcessTestHelper.newApplication();
+        org.kie.kogito.process.Process<MultipleMessageSignalSubprocessModel> 
process = MultipleMessageSignalSubprocessProcess.newProcess(app);
+        MultipleMessageSignalSubprocessModel model = process.createModel();
+        ProcessInstance<MultipleMessageSignalSubprocessModel> processInstance 
= process.createInstance(model);
+        processInstance.start();
+        logger.debug("Parent Process ID: " + processInstance.id());
+        processInstance.send(Sig.of("Message-Message 1", "Test"));
+        
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_ACTIVE);
+        processInstance.send(Sig.of("Message-Message 1", "Test"));
+        
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
     }
 
     @Test
-    public void testIntermediateCatchEventSignalWithRef() throws Exception {
-        kruntime = createKogitoProcessRuntime(
-                
"org/jbpm/bpmn2/intermediate/BPMN2-IntermediateCatchEventSignalWithRef.bpmn2");
-        kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human 
Task", new SystemOutWorkItemHandler());
-        KogitoProcessInstance processInstance = 
kruntime.startProcess("IntermediateCatchEventSignalWithRef");
-        assertProcessInstanceActive(processInstance);
+    public void testIntermediateCatchEventSignalWithRef() {
+        Application app = ProcessTestHelper.newApplication();
+        ProcessTestHelper.registerHandler(app, "Human Task", new 
SystemOutWorkItemHandler());
+        EventTrackerProcessListener listener = new 
EventTrackerProcessListener();
+        ProcessTestHelper.registerProcessEventListener(app, listener);
 
-        // now signal process instance
-        kruntime.signalEvent("Signal1", "SomeValue", 
processInstance.getStringId());
-        assertProcessInstanceFinished(processInstance, kruntime);
-        assertNodeTriggered(processInstance.getStringId(), "StartProcess", 
"UserTask", "EndProcess", "event");
+        
org.kie.kogito.process.Process<IntermediateCatchEventSignalWithRefModel> 
process = IntermediateCatchEventSignalWithRefProcess.newProcess(app);
+        IntermediateCatchEventSignalWithRefModel model = process.createModel();
+
+        ProcessInstance<IntermediateCatchEventSignalWithRefModel> 
processInstance = process.createInstance(model);
+        processInstance.start();
+
+        
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_ACTIVE);
 
+        processInstance.send(Sig.of("Signal1", "SomeValue"));
+
+        
assertThat(processInstance.status()).isEqualTo(ProcessInstance.STATE_COMPLETED);
+
+        List<String> nodes = listener.tracked().stream().map(e -> 
e.getNodeInstance().getNodeName()).toList();
+        assertThatIterable(nodes).contains("StartProcess", "UserTask", 
"EndProcess", "event");

Review Comment:
   See above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to