yesamer commented on code in PR #6083:
URL:
https://github.com/apache/incubator-kie-drools/pull/6083#discussion_r1760815178
##########
kie-dmn/kie-dmn-feel/pom.xml:
##########
@@ -144,7 +162,7 @@
<directory>${project.basedir}/src/test/resources</directory>
</testResource>
<testResource>
- <directory>${project.basedir}/</directory>
+ <directory>${project.basedir}/../</directory>
Review Comment:
@bncriju I guess this change is not required
##########
kie-dmn/kie-dmn-feel/pom.xml:
##########
@@ -135,6 +149,10 @@
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.poi</groupId>
+ <artifactId>poi</artifactId>
+ </dependency>
Review Comment:
@bncriju I guess this is not required
##########
kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/functions/MatchesFunction.java:
##########
@@ -39,21 +36,24 @@ private MatchesFunction() {
super( "matches" );
}
- public FEELFnResult<Boolean> invoke(@ParameterName("input") String input,
@ParameterName("pattern") String pattern) {
+ public FEELFnResult<Boolean> FEELFnResult(@ParameterName("input") String
input, @ParameterName("pattern") String pattern) {
Review Comment:
@bncriju Wrong method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
