tkobayas commented on code in PR #6096:
URL:
https://github.com/apache/incubator-kie-drools/pull/6096#discussion_r1768335141
##########
drools-test-coverage/test-compiler-integration/src/test/java/org/drools/compiler/integrationtests/TimerAndCalendarFireUntilHaltTest.java:
##########
@@ -109,9 +109,12 @@ public void testTimerRuleFires() throws Exception {
startEngine();
activateRule();
- advanceTimerOneSecond();
-
await().until(ruleHasFired("TimerRule", 1));
+
+ advanceTimerOneSecond();
+ await().until(ruleHasFired("TimerRule", 2));
Review Comment:
The flakiness was that `fireUntilHalt` may or may not fire a match between
`activateRule()` and `advanceTimerOneSecond()`. Usually, it doesn't fire, so
the assertion worked with `ruleHasFired("TimerRule", 1)`. However, to be
stable, the test has to wait the first firing before `advanceTimerOneSecond()`.
So the subsequent assertions are changed accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
