tiagobento commented on code in PR #2546:
URL:
https://github.com/apache/incubator-kie-tools/pull/2546#discussion_r1774140206
##########
packages/dmn-editor/src/diagram/edges/usePotentialWaypointControls.ts:
##########
@@ -96,18 +173,27 @@ export function usePotentialWaypointControls(
}
dmnEditorStoreApi.setState((state) => {
+ const dmnEdgeIndex =
state.computed(state).indexedDrd().dmnEdgesByDmnElementRef.get(edgeId)?.index;
+ if (dmnEdgeIndex === undefined) {
+ console.debug(`DMN MUTATION: DMNEdge for '${edgeId}' edge has missing
index.`);
+ return;
+ }
Review Comment:
I think we should `throw` here, as at this point, this operation should
never fail. If `edgeIndex` doesn't exist, you create a new edge, this querying
for the edgeId again should always give you a new edge. If that doesn't happen,
something exceptional happened, so we throw. Also not in a mutation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
