fjtirado commented on PR #6103: URL: https://github.com/apache/incubator-kie-drools/pull/6103#issuecomment-2376389312
Hi Mario, DummyKnowledgeRuntime should be a goner for good. Besides that, I think that the final result of the refactor (which I agree is a lengthy task) should be that the process engine (which is currently used by BPMN and Sonataflow) no longer depends on drools*. If we agree that's the goal, I believe it is better for you to work on that alone (meaning quietly, without continuous interference by me ;)). Once you have the PR, let's review it also quietly. * The dependency with drools should be in the RuleNode, which is the part of the engine related with rules. On Thu, Sep 26, 2024 at 10:58 AM Mario Fusco ***@***.***> wrote: > Thanks, Mario. > > GHA kogito-runtimes (and other downstreams): > > 2024-09-25T16:38:02.4742156Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project jbpm-flow: Compilation failure > 2024-09-25T16:38:02.4744813Z [ERROR] /home/runner/work/incubator-kie-drools/incubator-kie-drools/apache_incubator-kie-kogito-runtimes/jbpm/jbpm-flow/src/main/java/org/jbpm/process/instance/DummyKnowledgeRuntime.java:[65,1] org.jbpm.process.instance.DummyKnowledgeRuntime is not abstract and does not override abstract method <T>execute(org.kie.api.command.Command<T>) in org.kie.api.runtime.CommandExecutor > > DummyKnowledgeRuntime needs to implement execute or > CommandExecutor.execute should have a default implementation. > > This is the result of a *HUGE* technical debt caused by the tight > coupling between Drools and Kogito's processes that has no longer reason to > exist. I spent a couple of hours trying to refactor Kogito and lower this > coupling, but unfortunately this is clearly a multi-days effort, so I gave > up for now and fixed the issue in the most straightforward way with this > pull request apache/incubator-kie-kogito-runtimes#3681 > <https://github.com/apache/incubator-kie-kogito-runtimes/pull/3681> > > That said, I'm still willing to solve this debt with more calm when I will > have time to dedicate to this, possibly with the help of @elguardian > <https://github.com/elguardian> and @fjtirado > <https://github.com/fjtirado>. I already have a very preliminary question > for you 2: is that DummyKnowledgeRuntime still necessary for some reasons > (and why) or could it be totally removed? I'm asking because this seems to > be a hack that it is also a source of a big part of the issues that I found > during this first refactor attempt. > > @tkobayas <https://github.com/tkobayas> @gitgabrio > <https://github.com/gitgabrio> please review again. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-kie-drools/pull/6103#issuecomment-2376361616>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/APRXYPXKG2YRMXBDCZ3CXRTZYPEEDAVCNFSM6AAAAABO2ROFEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZWGM3DCNRRGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
