martinweiler commented on PR #3682:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3682#issuecomment-2379720789

   @Abhitocode re: _How can we assert this, what changes are made to child 
process instances after completing parent process._
   
   Wouldn't this not just be an issue of repeating this assert?
   ```
           List<ProcessInstance<DynamicSignalChildModel>> childInstances = 
childProcessDefinition.instances().stream().toList();
           assertThat(childInstances).hasSize(3);
           childInstances.forEach(instance -> 
assertThat(instance.status()).isEqualTo(ProcessInstance.STATE_ACTIVE));
   ```
   In this test, the parent/child sub-process relation is defined as 
independent, so the child instances should remain active even though the parent 
has finished.
   
   What about the tests in 
[FlowTest](https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/FlowTest.java#L780)
 - are you going to add them to this PR as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to