jomarko commented on PR #2655: URL: https://github.com/apache/incubator-kie-tools/pull/2655#issuecomment-2407378699
@yesamer hi, thank you for comments. In this message, lets discuss `Why after "package"`. I used https://creadur.apache.org/rat017/apache-rat/ tool for adding the headers, especially the `--edit-license` option. I and @jstastny-cz used this tool for licenses presence verification, so I thought using it for license addition will be not problematic. I see your point, that it is not consistent with the rest of similar files. Now it is question, if we have other automatic way of adding headers that would be: - compatible with the kie build - compatible with the existing headers placement - compatible with the `apache-rat` automatic checks or if we have other tool for apache licenses header checks Situation is even more complicated, for some yaml files related to helm-chart that I thought they need to license, running `pnpm format` will remove headers from them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
