mariofusco commented on PR #6119: URL: https://github.com/apache/incubator-kie-drools/pull/6119#issuecomment-2410259686
I've never seen any of those mentioned tests failing even once in my life. It is true that the values returned in that `Set` are iterated, but the order of iteration doesn't matter provided it is always stable during the same invocation. I believe those are all false negative generated by that NonIndex tool, and in this case replacing a `HashSet` with a `LinkedHashSet` for no valid reason implies and unnecessary performance cost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
