gmunozfe commented on code in PR #2114:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2114#discussion_r1801600790
##########
data-index/data-index-storage/data-index-storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java:
##########
@@ -174,13 +194,11 @@ private NodeInstanceEntity updateNode(NodeInstanceEntity
nodeInstance, ProcessIn
return nodeInstance;
}
- private void indexSLA(ProcessInstanceSLAEventBody data) {
- findOrInit(data.getProcessId(), data.getProcessInstanceId(),
data.getEventDate());
- repository.flush();
+ private void indexState(ProcessInstanceEntity pi,
ProcessInstanceStateDataEvent event) {
+ indexState(pi, event.getData(), event.getKogitoAddons() == null ?
Set.of() : Set.of(event.getKogitoAddons().split(",")), event.getSource() ==
null ? null : event.getSource().toString());
Review Comment:
You could also consider that `event.getKogitoAddons().isEmpty())` is empty
for the ternary operator.
```suggestion
indexState(pi, event.getData(), (event.getKogitoAddons() == null ||
event.getKogitoAddons().isEmpty()) ? Set.of() :
Set.of(event.getKogitoAddons().split(",")), event.getSource() == null ? null :
event.getSource().toString());
```
##########
data-index/data-index-storage/data-index-storage-jpa-common/src/main/java/org/kie/kogito/index/jpa/storage/ProcessInstanceEntityStorage.java:
##########
@@ -64,52 +67,73 @@ public
ProcessInstanceEntityStorage(ProcessInstanceEntityRepository repository,
super(repository, ProcessInstanceEntity.class, mapper::mapToModel);
}
+ @Override
+ @Transactional
+ public void indexGroup(MultipleProcessInstanceDataEvent events) {
+ Map<String, ProcessInstanceEntity> piMap = new HashMap<>();
+ for (ProcessInstanceDataEvent<?> event : events.getData()) {
+
indexEvent(piMap.computeIfAbsent(event.getKogitoProcessInstanceId(), id ->
findOrInit(event)), event);
+ }
+ }
+
@Override
@Transactional
public void indexError(ProcessInstanceErrorDataEvent event) {
- indexError(event.getData());
+ indexError(findOrInit(event), event.getData());
}
@Override
@Transactional
public void indexNode(ProcessInstanceNodeDataEvent event) {
- indexNode(event.getData());
+ indexNode(findOrInit(event), event.getData());
}
@Override
@Transactional
public void indexSLA(ProcessInstanceSLADataEvent event) {
- indexSLA(event.getData());
-
+ indexSla(findOrInit(event), event.getData());
}
@Override
@Transactional
public void indexState(ProcessInstanceStateDataEvent event) {
- indexState(event.getData(), event.getKogitoAddons() == null ? Set.of()
: Set.of(event.getKogitoAddons().split(",")), event.getSource() == null ? null
: event.getSource().toString());
+ indexState(findOrInit(event), event);
}
@Override
@Transactional
public void indexVariable(ProcessInstanceVariableDataEvent event) {
- indexVariable(event.getData());
+ indexVariable(findOrInit(event), event.getData());
}
- private ProcessInstanceEntity findOrInit(String processId, String
processInstanceId, Date date) {
- return repository.findByIdOptional(processInstanceId).orElseGet(() -> {
+ private ProcessInstanceEntity findOrInit(ProcessInstanceDataEvent<?>
event) {
+ return
repository.findByIdOptional(event.getKogitoProcessInstanceId()).orElseGet(() ->
{
ProcessInstanceEntity pi = new ProcessInstanceEntity();
- pi.setProcessId(processId);
- pi.setId(processInstanceId);
- pi.setLastUpdate(toZonedDateTime(date));
+ pi.setProcessId(event.getKogitoProcessId());
+ pi.setId(event.getKogitoProcessInstanceId());
+ pi.setLastUpdate(toZonedDateTime(event.getTime()));
Review Comment:
I guess `event.getTime()` cannot be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
