danielzhe commented on PR #2675: URL: https://github.com/apache/incubator-kie-tools/pull/2675#issuecomment-2420656516
I did some manual tests and I think it is working great! I wish we could have a better way to inform the user exactly what happened, but due to the nature of the `error.response` being `any`, I think what you did is what we can do for now since it can be anything. Just address what @pefernan suggested and from my point of view, we're good to merge. About the tests you mentioned in the private chat, we don't have any automated tests at all in this project so the manual tests you and the reviews did is what we have for now. Good work, @bncriju . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
