tiagobento commented on PR #2657: URL: https://github.com/apache/incubator-kie-tools/pull/2657#issuecomment-2421187915
<img width="417" alt="image" src="https://github.com/user-attachments/assets/c4d4247f-8ade-46db-ad35-18a49624425b";> Border looks a little off, and the tooltip says (beta), but it isn't. Also, I think the idea of having this as a https://www.patternfly.org/components/label/ instead of a "Button" is important to give it a different look compared to the other buttons, since this this is not really a button, but more like an indicator that the Evaluation highlights are turned on. Same is true for the toggle on BEE. We also need to be mindful of the case we choose when writing text on-screen. I always prefer to capitalize only the first word, not all words, so the label would read "Evaluation highlights: on/off", instead of "Evaluation Highlights: On/Off". Another thing that caught my eye was the little displacement that happened when the I toggled between on and off on BEE, because of difference in text size. Being mindful of layout shifts is also very important for a good experience when using a web app. Please consider my feedback, and let me know if you have questions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
