jomarko commented on code in PR #6135:
URL:
https://github.com/apache/incubator-kie-drools/pull/6135#discussion_r1810592146
##########
kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_5/Collections.dmn:
##########
@@ -0,0 +1,94 @@
+<?xml version="1.0" encoding="UTF-8" ?>
Review Comment:
I agree with the proposed name. Will push the change shortly.
##########
kie-dmn/kie-dmn-test-resources/src/test/resources/valid_models/DMNv1_5/RiskScore_Conditional.dmn:
##########
@@ -0,0 +1,328 @@
+<?xml version="1.0" encoding="UTF-8" ?>
Review Comment:
They are semantically slightly different.
The existing `RiskScore_Simple` contains two Decision nodes in a sequence.
Firstly, a decision table is evaluated in the first decision node and then the
model proceeds to the second decision node, where a conditional expression is
evaluated.
The new `RiskScore_Conditional` contains a single Decision node, where
expressions are nested so it is `Risk Score: {if: (condition), then:
{DecisionTable 1}, else: {DecisionTable 2}}`
I see this model as useful to demonstrate `evaluationHitIds` are returned
for all levels of the expressions - we return as conditional branch id, so
decision table rule id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
