gitgabrio commented on code in PR #3747:
URL:
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3747#discussion_r1812038007
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/StandaloneBPMNProcessTest.java:
##########
@@ -400,7 +400,7 @@ public void testEventBasedSplit2() throws Exception {
org.kie.kogito.process.ProcessInstance<EventBasedSplit2Model>
instanceTimer = processDefinition.createInstance(modelTimer);
instanceTimer.start();
assertThat(instanceTimer.status()).isEqualTo(org.kie.kogito.process.ProcessInstance.STATE_ACTIVE);
- countDownListener.waitTillCompleted();
+ countDownListener.waitTillCompleted(15000);
Review Comment:
@fjtirado @Ginxo
I find out that there are other (lot ?) of test that uses this
`waitTillCompleted` without checking the returned boolean. As per its
implementation, that method requires the returned boolean to be evaluated,
since it swallow-up any kind of problem (and, in the CI, logs are also hidden,
IINW)
```java
public boolean waitTillCompleted(long timeOut) {
try {
return latch.await(timeOut, TimeUnit.MILLISECONDS);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
logger.debug("Interrputed thread while waiting for all
triggers");
return false;
}
}```
So, Francisco, could you also please an assertion on the returned boolean,
to clearly indicate that the problem is the failure on the `waitTillCompleted`
method itself ?
Thanks!
@pefernan FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
