wmedvede commented on code in PR #551:
URL:
https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/551#discussion_r1813150043
##########
bundle/manifests/sonataflow-operator-controllers-config_v1_configmap.yaml:
##########
@@ -58,6 +58,9 @@ data:
- groupId: org.kie
artifactId: kie-addons-quarkus-persistence-jdbc
version: 999-20240912-SNAPSHOT
+ # If true, the workflow deployments will be configured to send accumulated
workflow status change events to the Data
+ # Index Service reducing the number of produced events. Set to false to
send individual events.
+ kogitoEventsGrouping: true
Review Comment:
@ricardozanini I don't want to contaminate the SPF definition with that
value, so, in the sonataflowplatform CRD , or the SonataFlow CRD, like we did
with the dbMigrator parameter.
Instead we have this.
1. At cluster level, people can enable/disable the kogitoEventsGrouping. By
default I configured the value true. Since after discussions in our meetings
and with @fjtirado it looks like the best suited configuration. So by default,
based on the kogitoEventsGrouping, we'll add the corresponding value to the
corresponding application.properties for every workflow.
2. BUT, if people wants to overwrite this value we set by default, for
whatever reason, they can go to the corresponding WF CRD configuraion and set
the equivalent env variable, that will overwrite the value the opeator set in
the application.properties.
So, with 1 and 2, we have a simple mechanims to configure the
kogitoEvensGrouping by default, and, people can always overwrite in particular
situations. Which, as it was investigated, is not the recommended approach.
Also note that the kogitoEventsGrouping is only for Workfllows and not for
DI and JS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
