gmunozfe commented on code in PR #2122:
URL:
https://github.com/apache/incubator-kie-kogito-apps/pull/2122#discussion_r1814703648
##########
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/messaging/KogitoIndexEventConverter.java:
##########
@@ -148,18 +150,26 @@ public void setObjectMapper(ObjectMapper objectMapper) {
private DataEvent<?> buildProcessInstanceDataEventVariant(CloudEvent
cloudEvent) throws IOException {
switch (cloudEvent.getType()) {
- case MultipleProcessInstanceDataEvent.TYPE:
- return buildDataEvent(cloudEvent, objectMapper,
MultipleProcessInstanceDataEvent::new, new
TypeReference<Collection<ProcessInstanceDataEvent<?>>>() {
- });
- case "ProcessInstanceErrorDataEvent":
+ case MultipleProcessInstanceDataEvent.MULTIPLE_TYPE:
+ MultipleProcessInstanceDataEvent dataEvent =
buildEvent(cloudEvent, objectMapper, MultipleProcessInstanceDataEvent::new);
+ if (cloudEvent.getData() != null) {
Review Comment:
If data is null, you could add a warn logger to trace it in an `else`
clause, wdyt?:
`LOGGER.warn("CloudEvent data is null for event of type: {}",
cloudEvent.getType()); `
##########
data-index/data-index-service/data-index-service-common/src/main/java/org/kie/kogito/index/service/messaging/KogitoIndexEventConverter.java:
##########
@@ -148,18 +150,26 @@ public void setObjectMapper(ObjectMapper objectMapper) {
private DataEvent<?> buildProcessInstanceDataEventVariant(CloudEvent
cloudEvent) throws IOException {
switch (cloudEvent.getType()) {
- case MultipleProcessInstanceDataEvent.TYPE:
- return buildDataEvent(cloudEvent, objectMapper,
MultipleProcessInstanceDataEvent::new, new
TypeReference<Collection<ProcessInstanceDataEvent<?>>>() {
- });
- case "ProcessInstanceErrorDataEvent":
+ case MultipleProcessInstanceDataEvent.MULTIPLE_TYPE:
+ MultipleProcessInstanceDataEvent dataEvent =
buildEvent(cloudEvent, objectMapper, MultipleProcessInstanceDataEvent::new);
+ if (cloudEvent.getData() != null) {
+ String contentType = cloudEvent.getDataContentType();
Review Comment:
If it's not binary, it's assumming that it's "application/json", isn't it?
But potentially it could be other even null
##########
data-audit/data-audit-common-service/src/main/java/org/kie/kogito/app/audit/json/JsonUtils.java:
##########
@@ -41,15 +38,7 @@ public static ObjectMapper getObjectMapper() {
}
public static ObjectMapper configure(ObjectMapper objectMapper) {
-
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
false);
- objectMapper.registerModule(JsonFormat.getCloudEventJacksonModule());
- objectMapper.registerModule(new JavaTimeModule());
-
- SimpleModule module = new SimpleModule("Kogito Cloud Events");
- module.addDeserializer(ProcessInstanceDataEvent.class, new
JsonProcessInstanceDataEventDeserializer());
- module.addDeserializer(UserTaskInstanceDataEvent.class, new
JsonUserTaskInstanceDataEventDeserializer());
- module.addDeserializer(JobInstanceDataEvent.class, new
JsonJobDataEventDeserializer());
- objectMapper.registerModule(module);
- return objectMapper;
+ return
objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
false).registerModule(JsonFormat.getCloudEventJacksonModule())
+ .registerModule(new SimpleModule("Data
Audit").addDeserializer(JobInstanceDataEvent.class, new
JsonJobDataEventDeserializer())).findAndRegisterModules();
Review Comment:
Is it not needed to register JavaTimeModule anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
