This is an automated email from the ASF dual-hosted git repository.
fantonangeli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
The following commit(s) were added to refs/heads/main by this push:
new fa0658be822 kie-issues#2654: [SonataFlow] Empty WF Instance page if
variables is null (#2683)
fa0658be822 is described below
commit fa0658be8229724ccc56acc0e64594d323c79cb1
Author: Fabrizio Antonangeli <[email protected]>
AuthorDate: Thu Oct 24 14:46:39 2024 +0200
kie-issues#2654: [SonataFlow] Empty WF Instance page if variables is null
(#2683)
---
.../components/WorkflowDetails/WorkflowDetails.tsx | 2 +-
.../components/WorkflowDefinitionList.test.tsx | 2 +-
.../tests/components/WorkflowDetails.test.tsx | 89 ++++++++++++++++++++++
3 files changed, 91 insertions(+), 2 deletions(-)
diff --git
a/packages/runtime-tools-swf-enveloped-components/src/workflowDetails/envelope/components/WorkflowDetails/WorkflowDetails.tsx
b/packages/runtime-tools-swf-enveloped-components/src/workflowDetails/envelope/components/WorkflowDetails/WorkflowDetails.tsx
index be5db3021d4..5f2ea170b45 100644
---
a/packages/runtime-tools-swf-enveloped-components/src/workflowDetails/envelope/components/WorkflowDetails/WorkflowDetails.tsx
+++
b/packages/runtime-tools-swf-enveloped-components/src/workflowDetails/envelope/components/WorkflowDetails/WorkflowDetails.tsx
@@ -252,7 +252,7 @@ const WorkflowDetails: React.FC<WorkflowDetailsProps> = ({
isEnvelopeConnectedTo
const renderWorkflowVariables = (): JSX.Element => {
return (
<Flex direction={{ default: "column" }} flex={{ default: "flex_1" }}>
- {Object.keys(updateJson).length > 0 && (
+ {updateJson && Object.keys(updateJson).length > 0 && (
<FlexItem>
<WorkflowVariables
displayLabel={displayLabel}
diff --git
a/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDefinitionList.test.tsx
b/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDefinitionList.test.tsx
index 6226790263e..f72efab13a2 100644
---
a/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDefinitionList.test.tsx
+++
b/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDefinitionList.test.tsx
@@ -18,7 +18,7 @@
*/
import * as React from "react";
-import { render, waitFor, screen, fireEvent, act } from
"@testing-library/react";
+import { render, waitFor, fireEvent } from "@testing-library/react";
import "@testing-library/jest-dom";
import WorkflowDefinitionList from
"@kie-tools/runtime-tools-swf-enveloped-components/dist/workflowDefinitions/envelope/components/WorkflowDefinitionList/WorkflowDefinitionList";
diff --git
a/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDetails.test.tsx
b/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDetails.test.tsx
new file mode 100644
index 00000000000..f54261b947a
--- /dev/null
+++
b/packages/runtime-tools-swf-enveloped-components/tests/components/WorkflowDetails.test.tsx
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import * as React from "react";
+import { render } from "@testing-library/react";
+import "@testing-library/jest-dom";
+import WorkflowDetails from
"@kie-tools/runtime-tools-swf-enveloped-components/dist/workflowDetails/envelope/components/WorkflowDetails/WorkflowDetails";
+import { WorkflowInstance, WorkflowInstanceState } from
"@kie-tools/runtime-tools-swf-gateway-api/dist/types";
+
+const mockDriver = {
+ jobsQuery: jest.fn(),
+};
+
+const sampleWorkflowDetails: WorkflowInstance = {
+ id: "6d114aaf-b599-49da-b434-f18133b40072",
+ processId: "timeout",
+ processName: "timeout",
+ variables: {
+ workflowdata: {
+ varName: "value",
+ },
+ },
+ state: WorkflowInstanceState.Active,
+ start: new Date("2024-10-18T12:25:00.192Z"),
+ lastUpdate: new Date("2024-10-18T12:25:00.192Z"),
+ endpoint: "http://localhost:4000/timeout";,
+ nodes: [],
+};
+
+describe("WorkflowDetails component", () => {
+ beforeEach(() => {
+ jest.clearAllMocks();
+ });
+
+ test("should render the workflow details correctly", () => {
+ const component = render(
+ <WorkflowDetails
+ isEnvelopeConnectedToChannel={true}
+ driver={mockDriver as any}
+ workflowDetails={sampleWorkflowDetails}
+ />
+ );
+
+ expect(component.queryByText("6d114")).toBeInTheDocument();
+ });
+
+ test.each([
+ [undefined, false],
+ [null, false],
+ [{}, false],
+ [{ workflowdata: {} }, true],
+ [sampleWorkflowDetails.variables, true],
+ ])(
+ "should render the workflow Variables card correctly when variables is
`%j`",
+ (variablesMock, variablesCardVisible) => {
+ const workflowDetailsMock = { ...sampleWorkflowDetails, variables:
variablesMock };
+ const component = render(
+ <WorkflowDetails
+ isEnvelopeConnectedToChannel={true}
+ driver={mockDriver as any}
+ workflowDetails={workflowDetailsMock}
+ />
+ );
+
+ if (variablesCardVisible) {
+ expect(component.queryByText("Variables")).toBeInTheDocument();
+ expect(component.queryByText("workflowdata")).toBeInTheDocument();
+ } else {
+ expect(component.queryByText("Variables")).not.toBeInTheDocument();
+ }
+ }
+ );
+});
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
