tiagobento commented on code in PR #2697:
URL:
https://github.com/apache/incubator-kie-tools/pull/2697#discussion_r1820031420
##########
packages/kogito-db-migrator-tool/package.json:
##########
@@ -0,0 +1,33 @@
+{
+ "private": true,
+ "name": "@kie-tools/kogito-db-migrator-tool",
+ "version": "0.0.0",
+ "description": "",
+ "license": "Apache-2.0",
+ "homepage": "https://github.com/apache/incubator-kie-tools";,
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/apache/incubator-kie-tools.git";
+ },
+ "bugs": {
+ "url": "https://github.com/apache/incubator-kie-tools/issues";
+ },
+ "scripts": {
+ "build:dev": "pnpm install && ./build-db-migrator-jar.sh true",
+ "build:prod": "pnpm install && ./build-db-migrator-jar.sh false",
Review Comment:
I guess this is the third time I'm commenting in this file.. Not sure where
my comments are going because they're not here anymore 😅
`pnpm install` is not really a command we should be running as part of the
build. Also, please remove the indirection and place commands directly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
