gitgabrio commented on PR #2031:
URL: 
https://github.com/apache/incubator-kie-kogito-examples/pull/2031#issuecomment-2449952604

   Hi @Abhitocode Thanks for the PR!
   
   Some comments:
   
   1. please declare the newly added `business-calendar-example` module to 
parent pom
   2. please add a pom.xml to this new module
   3. please add some integration tests - if this example is using something 
already tested in kogito-runtimes, you may use the same approach, even if 
behind a rest invocation
   4. is this correct -> `business.cal.timezone= system default timezone..`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to