gitgabrio commented on issue #1460:
URL: 
https://github.com/apache/incubator-kie-issues/issues/1460#issuecomment-2457570714

   @elguardian @fjtirado 
   I've investigated a bit more deeper.
   
   1. rules requires pre-compiled classes: if a drl file refers to some java 
bean, this has to be already compiled to be found, otherwise drl compilation 
fails
   2. while it could be "simpler" to remove pre-compile need for process, this 
seems extremely hard for rules; and since rules and processes could (and often 
does) live in the same project, point 1. prevent removal of pre-compile phase
   3. what could be improved, is that instead of invoking maven compiler to 
re-compile "blindly" everything, we could manually compile and dump only the 
newly generated classes
   4. the other thing that could be refactored is the ProcessClassesMojo that, 
IIUC, uses Reflection (and precompiled classes) to code-generate 
persistence-related classes, that later on are manually compiled and dumped.
   
   To recap, I think we can't escape from "pre-compile" (as happen in the 
kie-maven-plugin) but we can provide that code-generation happen only once soon 
after, and that later only newly code-generated sources will be compiled/dumped.
   
   I add @mariofusco to also have his opinion on that, especially about the 
rule part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to