tkobayas commented on code in PR #6149:
URL:
https://github.com/apache/incubator-kie-drools/pull/6149#discussion_r1839678356
##########
pom.xml:
##########
@@ -135,6 +135,10 @@
<version>${version.apache-rat-plugin}</version>
<configuration>
<excludes>
+ <exclude>.rat-excludes</exclude>
+ <exclude>.gitignore</exclude>
+ <exclude>DISCLAIMER-WIP</exclude>
+ <exclude>**/ui-bundle.zip</exclude>
Review Comment:
Unfortunately, we cannot share the same `.rat-excludes` file for `java -jar
apache-rat-0.16.1.jar -E` command line and `<excludesFile>` in
`apache-rat-plugin`, because command line expects that the exclude files is
written with regular expression (e.g. `.*\.csv`) while `apache-rat-plugin`
expects the exclude files is written with glob pattern (e.g. `**/*.csv`).
Maintaining both configurations is a little cumbersome.
With this PR, we can check license headers with GHA and also with command
line locally. Shall I remove `apache-rat-plugin` from pom.xml? @baldimir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
