samuel-beniamin commented on PR #6105:
URL: 
https://github.com/apache/incubator-kie-drools/pull/6105#issuecomment-2473876419

   Hello @gitgabrio 
   
   Well, I tried the approach of the a separate subclass for Signavio specific 
things, I have some observation and a conclusion: 
   1. I ended up not able to inject that Signavio specific compiler easily into 
the code.
   2. `DMNCompilerConfiguration` is not Signavio specific, this is related to 
the core compiler for extensions in general. 
   3. `drgCompilers` are not Signavio specific, they are also used by other 
extensions, (e.g. `trisotech` is also using that).
       * This makes me think that `AfterProcessDrgElements` follows the same 
reasoning, is not Signavio specific (since `drgCompilers` are not), 
`AfterProcessDrgElements` is indeed used only now by Signavio, but that doesn't 
limit the need to Signavio only.
   
   I have a question, do you know a way with which I can integrate the new 
compiler into the code by any means, I had the impression that the compiler is 
not intended to be changed but extended through the `DMNCompilerConfiguration` 
only, am I correct?
   
   If I am correct on the previous point, I would actually close this ticket 
after rethinking this part and also close the ticket, since this is the way the 
compiler was meant to be extended actually.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to