This is an automated email from the ASF dual-hosted git repository.
fjtiradosarti pushed a commit to branch main
in repository
https://gitbox.apache.org/repos/asf/incubator-kie-kogito-runtimes.git
The following commit(s) were added to refs/heads/main by this push:
new 5876428c38 checkout kie-kogito-runtimes-3770: Use the workflow id as
the auto-generated value for the name, when the workflow definition has no
value in the attribute name (#3771)
5876428c38 is described below
commit 5876428c38e9b0afcfa8355bead7c5b8483bead9
Author: Walter Medvedeo <[email protected]>
AuthorDate: Wed Nov 13 14:54:30 2024 +0100
checkout kie-kogito-runtimes-3770: Use the workflow id as the
auto-generated value for the name, when the workflow definition has no value in
the attribute name (#3771)
---
.../kogito/serverless/workflow/parser/ServerlessWorkflowParser.java | 3 +--
.../kie/kogito/serverless/workflow/ServerlessWorkflowParsingTest.java | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git
a/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/ServerlessWorkflowParser.java
b/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/ServerlessWorkflowParser.java
index 49e16462cc..5e4c075e69 100644
---
a/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/ServerlessWorkflowParser.java
+++
b/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/main/java/org/kie/kogito/serverless/workflow/parser/ServerlessWorkflowParser.java
@@ -68,7 +68,6 @@ public class ServerlessWorkflowParser {
public static final String NODE_START_NAME = "Start";
public static final String NODE_END_NAME = "End";
- public static final String DEFAULT_NAME = "workflow";
public static final String DEFAULT_PACKAGE = "org.kie.kogito.serverless";
public static final String DEFAULT_VERSION = "1.0";
@@ -127,7 +126,7 @@ public class ServerlessWorkflowParser {
private GeneratedInfo<KogitoWorkflowProcess> parseProcess() {
RuleFlowProcessFactory factory =
RuleFlowProcessFactory.createProcess(workflow.getId(), !workflow.isKeepActive())
- .name(workflow.getName() == null ? DEFAULT_NAME :
workflow.getName())
+ .name(workflow.getName() == null ? workflow.getId() :
workflow.getName())
.version(workflow.getVersion() == null ? DEFAULT_VERSION :
workflow.getVersion())
.packageName(workflow.getMetadata() != null ?
workflow.getMetadata().getOrDefault("package",
DEFAULT_PACKAGE) : DEFAULT_PACKAGE)
diff --git
a/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/test/java/org/kie/kogito/serverless/workflow/ServerlessWorkflowParsingTest.java
b/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/test/java/org/kie/kogito/serverless/workflow/ServerlessWorkflowParsingTest.java
index e140cb54b8..6041dbbdf9 100644
---
a/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/test/java/org/kie/kogito/serverless/workflow/ServerlessWorkflowParsingTest.java
+++
b/kogito-serverless-workflow/kogito-serverless-workflow-builder/src/test/java/org/kie/kogito/serverless/workflow/ServerlessWorkflowParsingTest.java
@@ -642,7 +642,7 @@ public class ServerlessWorkflowParsingTest extends
AbstractServerlessWorkflowPar
ServerlessWorkflowParser parser =
ServerlessWorkflowParser.of(workflow, JavaKogitoBuildContext.builder().build());
Process process = parser.getProcessInfo().info();
assertThat(parser.getProcessInfo().info()).isSameAs(process);
-
assertThat(process.getName()).isEqualTo(ServerlessWorkflowParser.DEFAULT_NAME);
+ assertThat(process.getName()).isEqualTo(workflow.getId());
assertThat(process.getVersion()).isEqualTo(ServerlessWorkflowParser.DEFAULT_VERSION);
assertThat(process.getPackageName()).isEqualTo(ServerlessWorkflowParser.DEFAULT_PACKAGE);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
