jomarko commented on PR #2726:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475494655

   ### 
kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
   is not consistent in naming:
   - 
`kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension`
   - vs 
`@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension`,
 
   
   this is also incompatible with the build command [1] 
`KIE_TOOLS_BUILD__buildExamples=true pnpm -F 
@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^...
 build:dev`
   
   Probably also `build:prod` command should contain `-F` part.
   
   πŸ”΄  build command [1] failed 
   ```
   β”‚ > copyfiles -u 1 "src/**/*.{sass,scss,css}" dist/
   └─ Running...
   packages/vscode-extension build:dev$ rimraf dist && tsc -p tsconfig.json
   β”‚ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(33,27): error 
TS2307: Cannot find module 'isomorphic-git' or its corresponding type 
declarations.
   β”‚ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(81,10): error 
TS7006: Parameter 'p' implicitly has an 'any' type.
   └─ Failed in 9.5s at /home/jomarko/kie-tools/packages/vscode-extension
   /home/jomarko/kie-tools/packages/vscode-extension:
    ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kie-tools-core/[email protected] 
build:dev: `rimraf dist && tsc -p tsconfig.json`
   Exit status 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to