LightGuard commented on code in PR #6153:
URL:
https://github.com/apache/incubator-kie-drools/pull/6153#discussion_r1844314579
##########
DISCLAIMER-BINARY:
##########
@@ -31,4 +31,4 @@ These files are used to validate the functionality and
reliability of Apache KIE
The following binaries are included in this project, but don't contain
compiled resources.
-drools-docs/ui-bundle/ui-bundle.zip : antora ui-bundle resources. For example,
js and svg. See NOTICE file
\ No newline at end of file
+drools-docs/ui-bundle/ui-bundle.zip : antora ui-bundle resources. For example,
js and svg. See LICENSE-BINARY file
Review Comment:
I'm wondering if we drop the docs stuff from the releases all together.
@porcelli what do you think?
##########
LICENSE-BINARY:
##########
@@ -200,3 +200,13 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+------------------------------------------------------------------------------------
+This product bundles various third-party components under other open source
licenses.
+This section summarizes those components and their licenses. See
licenses-binary/
+for text of these licenses.
+
+Mozilla Public License 2.0
Review Comment:
Shouldn't we be including the license text here too, or at the very least a
link to the license?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
