tkobayas commented on code in PR #3714:
URL: 
https://github.com/apache/incubator-kie-kogito-runtimes/pull/3714#discussion_r1851435478


##########
LICENSE:
##########
@@ -199,3 +199,13 @@
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
+
+
+------------------------------------------------------------------------------------
+for jbpm/jbpm-bpmn2/src/main/resources/META-INF/BPMN20.xsd
+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/BPMNDI.xsd
+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/DC.xsd
+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/DI.xsd
+    jbpm/jbpm-bpmn2/src/main/resources/META-INF/Semantic.xsd
+
+TODO put license text for files listed above here.

Review Comment:
   I don't know when https://issues.apache.org/jira/browse/LEGAL-690 will be 
answered, but I hope it wouldn't be a blocker for 10.0.0 release. At least for 
this PR, I think you can keep the "TODO", or align with drools main 
(https://github.com/apache/incubator-kie-drools/blob/main/LICENSE#L248-L382 , 
note that it was taken from DMN spec, it might be slightly different from BPMN 
spec). @porcelli thoughts?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to