tkobayas commented on PR #2746: URL: https://github.com/apache/incubator-kie-tools/pull/2746#issuecomment-2496962677
Thank you for the huge efforts on the PR updates @jomarko ! Let's revisit the points which Justin mentioned in the ML thread. https://lists.apache.org/thread/nrq50szwx37doopb23wyq33v0t3bbccg ``` The LICENSE is misisng information about bundled 3rd party files e.g [2][3][4][5][6][10][11] and many other 3rd party files. Files like [3][6[9] seem to incorrectly have an ASF header on them when the copyright belongs to someone else. How are these file licensed? Minified code should, if possible, be kept out of a source release. [8][9] This file is GPL or CDDL licensed and shouldn't be included in an ASF release. [11] 2. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/third_party/errai/src/main/java/org/jboss/errai/common/client/util/Base64Util.java 5. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/lienzo-core/src/main/java/com/ait/lienzo/client/core/event/OrientationChangeHandler.java (and many other files) 7. ./incubator-kie-tools/packages/stunner-editors/lienzo-webapp/src/main/java/org/kie/lienzo/client/LienzoExamples.native.js 8. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/jspdf.min.js.back 10 ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/canvas2svg.js.back 11. ./incubator-kie-tools/packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/compat/javax/annotation/processing/Generated.java ``` ---- 2. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/third_party/errai/src/main/java/org/jboss/errai/common/client/util/Base64Util.java Same issue -> ./packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/client/util/Base64Util.java -> **Please add them to `LICENSE` with the notes:** ``` This code is a modified version of Base64Encoder from http://code.google.com/p/gwt-crypto/source/browse/trunk/src/main/java/com/googlecode/gwt/crypto/bouncycastle/util/encoders/Base64.java, used under the terms of the ASL 2.0 license. ``` 5. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/lienzo-core/src/main/java/com/ait/lienzo/client/core/event/OrientationChangeHandler.java (and many other files) -> Already done 7. ./incubator-kie-tools/packages/stunner-editors/lienzo-webapp/src/main/java/org/kie/lienzo/client/LienzoExamples.native.js -> Already done 8. ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/jspdf.min.js.back -> **Please add it to `LICENSE` with the all copyright comments and MIT license** 10 ./incubator-kie-tools/packages/serverless-workflow-diagram-editor/uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/resources/org/uberfire/ext/editor/commons/client/file/exports/js/canvas2svg.js.back -> **Please add it to `LICENSE` with the copyright and MIT license** 11. ./incubator-kie-tools/packages/stunner-editors/errai-common/src/main/java/org/jboss/errai/common/compat/javax/annotation/processing/Generated.java -> Already done I don't know what we can do with "Minified code", but I hope it's not a blocker of 10.0.0. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
