jomarko commented on issue #2759:
URL: 
https://github.com/apache/incubator-kie-tools/issues/2759#issuecomment-2505681909

   Hi @phungvannarich-kepler-aavn @thiagoelg 
   
   It seems we have three issues with the same root cause:
   - https://github.com/apache/incubator-kie-tools/issues/2759
   - https://github.com/apache/incubator-kie-tools/issues/2670
   - https://github.com/apache/incubator-kie-issues/issues/387
   
   I wanted to ask what is your idea about refactoring the settings modal to be 
single property **Href** / **Url**. From my point of view it would be more 
aligned with the environment property configuration 
**KIE_SANDBOX_EXTENDED_SERVICES_URL**
   
   Here I share how it would look like and also attaching log from the browser 
log, where correct ping is executed (it is red because I didn't have extended 
services running on such address).
   ### Href/URL single setting
   ![Screenshot 2024-11-28 
102735](https://github.com/user-attachments/assets/06961c4b-5d9b-4fea-853d-b5b846b64059)
   ### Browser console log
   ![Screenshot 2024-11-28 
102753](https://github.com/user-attachments/assets/a4c3ef32-87f0-4c69-9f4c-8a9e5de0e6c8)
   
   With similar change, we should also think, if the advanced settings of the 
extended services wizard in the current form makes sense.
   
   ### Advanced settings extended services wizard
   ![Screenshot 2024-11-28 
103023](https://github.com/user-attachments/assets/e3728221-8395-4b9a-a16d-6c6e5ce6926f)
   
   the problem is all that part from screenshot does not take into an account a 
case, when the url has a form:
   `[host][port][pathname]: http://localhost:21345/my-extended-services/`
   it assumes only:
   `[host][port]: http://localhost:21345/`
   
   On my fork, I have a branch **kie-tools-issues#2759** with the 
[commit](https://github.com/jomarko/kie-tools/commit/af6be7cff79f007b10fa12b1eeea2a6c5c3809fc)
 that brings similar changes. Let me know, what you think about similar 
approach.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to