yesamer commented on code in PR #3757: URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3757#discussion_r1861952387
########## kogito-maven-plugin-test/pom.xml: ########## @@ -0,0 +1,187 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <parent> + <groupId>org.kie.kogito</groupId> + <artifactId>kogito-build-parent</artifactId> + <version>999-SNAPSHOT</version> + <relativePath>../kogito-build/kogito-build-parent/pom.xml</relativePath> + </parent> + + <artifactId>kogito-maven-plugin-test</artifactId> + + + <properties> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <version.org.springframework.boot>3.2.6</version.org.springframework.boot> + <version.surefire.plugin>3.1.2</version.surefire.plugin> + <version.jar.plugin>3.2.0</version.jar.plugin> Review Comment: @gitgabrio Why do we need those version declarations? It seems to me that jar and surefire plugins are inherited by the parent pom. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
