tkobayas commented on PR #6188: URL: https://github.com/apache/incubator-kie-drools/pull/6188#issuecomment-2530679357
Hi @yesamer , > Can you please update the rat-excludes file accordingly with the removed files? Thank you! I completely forgot the point. Fixed. > In addition, I searched for changeSet key in the repo, and I found 240+ usages. Are those usage still required? Yes. Some classes use the name `ChangeSet` for different capability, which handles differences between current version and next version of kieModule. They are still required. This PR removed the feature related to "change-set.xml" file, which is no longer functional nor tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@kie.apache.org For additional commands, e-mail: commits-h...@kie.apache.org