kbowers-ibm commented on code in PR #2816:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2816#discussion_r1886967302


##########
packages/dmn-editor/src/svg/DmnDiagramSvg.tsx:
##########
@@ -227,7 +227,7 @@ export function DmnDiagramSvg({
               <Text
                 key={i}
                 lineHeight={fontStyle.lineHeight}
-                style={{ ...fontStyle }}
+                style={{ ...fontStyle, fill: fontStyle.color }}

Review Comment:
   Instead of explicitly adding the fill property here, it's probably a bit 
cleaner to set it in the fontStyle the way the rest of the properties do



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to