rhkp commented on code in PR #2697:
URL: 
https://github.com/apache/incubator-kie-tools/pull/2697#discussion_r1889319714


##########
packages/kogito-db-migrator-tool-image/README.md:
##########
@@ -0,0 +1,116 @@
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+     http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+-->
+
+# Kogito Postgres DB Migrator Tool Image
+
+This package contains the `Containerfile/Dockerfile` and scripts to build a 
container image for Kogito Postgres DB Migrator Tool. Details about the Kogito 
Postgres DB Migrator Tool can be found 
[here](../kogito-db-migrator-tool/README.md).
+
+## Additional requirements
+
+- docker
+
+## Build
+
+_NOTE_: Before performing this step, be sure that the Kogito Postgres DB 
Migrator Tool jar has been built and available for inclusion in the image.
+
+- Enable the image to be built:
+
+  ```bash
+  export KIE_TOOLS_BUILD__buildContainerImages=true
+  ```
+
+Run the following in the root folder of the repository to build the package:
+
+```bash
+pnpm -F @kie-tools/kogito-db-migrator-tool-image... build:prod

Review Comment:
   The null appears when ${revision} variable is not set.
   You can add properties section in pom.xml as follows
   `  <properties>
       <revision>1.2.3</revision>
     </properties>`
   
   Which will have revision above instead of null, as below:
   `packages/kogito-db-migrator-tool build:prod: [INFO] --- 
install:3.1.3:install (default-install) @ sonataflow-db-migrator ---
   packages/kogito-db-migrator-tool build:prod: [INFO] Installing 
/home/ubuntu/flpath-1775/incubator-kie-tools/packages/kogito-db-migrator-tool/.flattened-pom.xml
 to 
/home/ubuntu/.m2/repository/org/kie/kogito/sonataflow-db-migrator/1.2.3/sonataflow-db-migrator-1.2.3.pom
   packages/kogito-db-migrator-tool build:prod: [INFO] Installing 
/home/ubuntu/flpath-1775/incubator-kie-tools/packages/kogito-db-migrator-tool/target/sonataflow-db-migrator-1.2.3.jar
 to 
/home/ubuntu/.m2/repository/org/kie/kogito/sonataflow-db-migrator/1.2.3/sonataflow-db-migrator-1.2.3.jar
   packages/kogito-db-migrator-tool build:prod: [INFO] Installing 
/home/ubuntu/flpath-1775/incubator-kie-tools/packages/kogito-db-migrator-tool/target/sonataflow-db-migrator-1.2.3-sources.jar
 to 
/home/ubuntu/.m2/repository/org/kie/kogito/sonataflow-db-migrator/1.2.3/sonataflow-db-migrator-1.2.3-sources.jar
   packages/kogito-db-migrator-tool build:prod: [INFO] Installing 
/home/ubuntu/flpath-1775/incubator-kie-tools/packages/kogito-db-migrator-tool/target/sonataflow-db-migrator-1.2.3-test-sources.jar
 to 
/home/ubuntu/.m2/repository/org/kie/kogito/sonataflow-db-migrator/1.2.3/sonataflow-db-migrator-1.2.3-test-sources.jar
   packages/kogito-db-migrator-tool build:prod: [INFO] 
------------------------------------------------------------------------
   packages/kogito-db-migrator-tool build:prod: [INFO] BUILD SUCCESS
   `



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to