gitgabrio commented on code in PR #6200:
URL:
https://github.com/apache/incubator-kie-drools/pull/6200#discussion_r1893552254
##########
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/impl/DMNRuntimeImpl.java:
##########
@@ -754,6 +760,15 @@ private static String getDependencyIdentifier(DMNNode
callerNode, DMNNode node)
}
+ private static void identifyDecisionErrors(DMNModel model, String...
decisions) {
+ List<DMNMessage> errorMessages =
model.getMessages(DMNMessage.Severity.ERROR);
+ List<String> identifiedErrors =
errorMessages.stream().map(Message::getText)
Review Comment:
HI @AthiraHari77
Many thanks for the PR.
I'm only slightly concerned about this assertion.
The logic here is that
1) `decisions` could be `decisionsId` or `decisionName` (IINW)
2) if an error message _**contains**_ one of them, then the decisions it
relates to is "wrong"
I'm afraid there could be some cases where an error message contains the
decisionId or decisionName, but that the error is not in the decision itself
(e.g. another element that refer that decision)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
