rhkp commented on code in PR #2790:
URL:
https://github.com/apache/incubator-kie-tools/pull/2790#discussion_r1894296522
##########
packages/sonataflow-operator/api/v1alpha08/sonataflow_persistence_types.go:
##########
@@ -17,6 +17,14 @@
package v1alpha08
+type DBMigrationStrategyType string
+
+const (
+ DBMigrationStrategyService DBMigrationStrategyType = "service"
+ DBMigrationStrategyJob DBMigrationStrategyType = "job"
Review Comment:
@wmedvede @ricardozanini I have updated the names as suggested, as follows
type DBMigrationOperatorType string
const (
DBMigrationOperatorService DBMigrationOperatorType = "service"
DBMigrationOperatorJob DBMigrationOperatorType = "job"
DBMigrationOperatorNone DBMigrationOperatorType = "none"
)
##########
packages/sonataflow-operator/api/v1alpha08/sonataflow_persistence_types.go:
##########
@@ -17,6 +17,14 @@
package v1alpha08
+type DBMigrationStrategyType string
+
+const (
+ DBMigrationStrategyService DBMigrationStrategyType = "service"
+ DBMigrationStrategyJob DBMigrationStrategyType = "job"
Review Comment:
I am fine with suggested naming. @ricardozanini please confirm and we will
replace it across the board from:
- `DBMigrationStrategyService` to `DBMigrationServiceOperator`
- `DBMigrationStrategyJob` to `DBMigrationJobOperator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
