fantonangeli opened a new pull request, #2858: URL: https://github.com/apache/incubator-kie-tools/pull/2858
The vars to build the kie-samples repository URL were hardcoded and this PR implemented the use of 2 env vars: - SERVERLESS_LOGIC_WEB_TOOLS__samplesRepositoryOrg - SERVERLESS_LOGIC_WEB_TOOLS__samplesRepositoryName We don't have an issue for this but I'm available to create a one. **How to test:** - build `serverless-logic-web-tools` - start the package with: `SERVERLESS_LOGIC_WEB_TOOLS__samplesRepositoryOrg="kubesmarts" SERVERLESS_LOGIC_WEB_TOOLS__samplesRepositoryName="sandbox-catalog" SERVERLESS_LOGIC_WEB_TOOLS__samplesRepositoryRef="main" pnpm start` - start `cors-proxy` in a different terminal - Open Chrome and the Developer Tools in incognito mode to force the samples to be downloaded - Browse https://localhost:9020/#/sample-catalog - The "Network" tab in the Developer Tools should show some downloads from: https://api.github.com/repos/kubesmarts/sandbox-catalog/... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
