jomarko commented on code in PR #2720:
URL:
https://github.com/apache/incubator-kie-tools/pull/2720#discussion_r1916982029
##########
packages/dmn-editor-envelope/src/DmnEditorFactory.tsx:
##########
@@ -42,7 +42,7 @@ export class DmnEditorFactory implements
EditorFactory<Editor, KogitoEditorChann
}
export class DmnEditorInterface implements Editor {
- private self: DmnEditorRoot;
+ protected self: DmnEditorRoot;
Review Comment:
I think I do not have answer that you would like to hear. This was the only
way I was able to access introduced `openBoxedExpressionEditor` from the
`NewDmnEditorInterface`. My understanding is we need to have both:
- `DmnEditorFactory` and `NewDmnEditorFactory`
- `DmnEditorInterface` and `NewDmnEditorInterface`
to capture the fact, that new editor does support opening boxed expressions
while the old one does not (from communication between packages point of view).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
