wmedvede commented on PR #2697: URL: https://github.com/apache/incubator-kie-tools/pull/2697#issuecomment-2596069297
> 1. If we want to include "postgresql" in the name of the packages; and @tiagobento @rhkp @ricardozanini Even while now the db-migrator only incorporate the sql files for postgresql, it is very close to be a multi database migrator :rocket:. In fact, I was about to suggest that in my reviews, by incorporating an additional parameter "db-type"...., but I didn't want to add more changes to not frustrate the PR author with more suggestions :). But I'm pretty sure that in the future... more db-types will come. So I'd vote for keeping the naming as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
